-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(governance): add check for strict Multisig threshold validation #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #177 +/- ##
=======================================
Coverage 98.68% 98.69%
=======================================
Files 48 48
Lines 763 764 +1
Branches 160 160
=======================================
+ Hits 753 754 +1
Misses 1 1
Partials 9 9 ☔ View full report in Codecov by Sentry. |
Rename PR to |
milapsheth
reviewed
Jun 26, 2024
blockchainguyy
changed the title
feat: add check for strict Multisig threshold validation
fix(governance): add check for strict Multisig threshold validation
Jun 26, 2024
milapsheth
reviewed
Jun 26, 2024
Co-authored-by: Milap Sheth <[email protected]>
Co-authored-by: Milap Sheth <[email protected]>
Co-authored-by: Milap Sheth <[email protected]>
Co-authored-by: Milap Sheth <[email protected]>
milapsheth
reviewed
Jun 30, 2024
milapsheth
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Strict Weighted Multisig threshold validation
This PR adds a check to revert if there are any leftover signatures, when threshold is crossed to make the threshold validation strict.
Jira Ticket