fix(storageLayout, readme): update hardhat config for storageLayout and updated readme #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and updated readme
milapsheth
reviewed
Aug 22, 2024
| @@ -4,6 +4,10 @@ Axelar Amplifier Gateway is a smart contract that lives on the external chain th | |||
|
|
|||
| Please see the [INTEGRATION.md](INTEGRATION.md) for more details on how to implement and integrate the external gateway contract for a given chain. | |||
|
|
|||
| ## Documentation & Build | |||
|
|
|||
| Please refer to [README.md](https://github.com/axelarnetwork/axelar-gmp-sdk-solidity/blob/main/README.md) for documentation and build instructions. | |||
| @@ -35,11 +35,18 @@ const optimizerSettings = { | |||
| }, | |||
| }; | |||
|
|
|||
| const outputSelectionSettings = { | |||
| "*": { | |||
| "*": ["storageLayout"], | |||
There was a problem hiding this comment.
can you exclude test contracts, and the build artifacts column?
There was a problem hiding this comment.
I looked up outputSelection option in detail, it enables outputs of storageLayout but does not have option to exclude test contracts and build artifacts.
https://docs.soliditylang.org/en/v0.8.20/using-the-compiler.html#input-description
| const defaultSettings = { | ||
| version: '0.8.23', | ||
| settings: { | ||
| evmVersion: process.env.EVM_VERSION || 'london', | ||
| optimizer: optimizerSettings, | ||
| outputSelection: outputSelectionSettings, |
There was a problem hiding this comment.
coverage action is failing, maybe because this should only be set if the storage layout env is set?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
AXE-4606
Executing the command
STORAGE_LAYOUT=true npx hardhat checkreturns:Fix
added outputSelection configuration for storageLayout.
After Fix:
STORAGE_LAYOUT=true npx hardhat checkNote: