-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: create gmp tracker event interface #186
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #186 +/- ##
=======================================
Coverage 98.66% 98.66%
=======================================
Files 47 47
Lines 747 747
Branches 154 154
=======================================
Hits 737 737
Misses 1 1
Partials 9 9 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- For our RFQ, sender won't be on the chain that this event is being emitted, the sender of the transaction being emitted will just be a relayer for our settlement process, so this should be a string. Could be a sender from Sui, Sol, or Cosmos.
- We don't have decimals available, so wouldn't be able to emit that.
- Swaps have a fromToken and toToken, so a bridge amount and single tokenAddress is less relevant here. Better to have fromToken, fromAmount, toToken and toAmount for us. We could arbitrarily pick the destination token if you want just one.
|
|
Co-authored-by: Milap Sheth <[email protected]>
Co-authored-by: Milap Sheth <[email protected]>
Co-authored-by: Milap Sheth <[email protected]>
b65ff0c
to
154ee3e
Compare
154ee3e
to
586d3fd
Compare
Looking good, for our RFQ we will always emit from source on the hub chain. If you add decimals back in, we won't be able to support anyway and would leave at 0 |
Co-authored-by: Milap Sheth <[email protected]>
Co-authored-by: Milap Sheth <[email protected]>
Co-authored-by: Milap Sheth <[email protected]>
Co-authored-by: Milap Sheth <[email protected]>
Co-authored-by: Milap Sheth <[email protected]>
Hey guys, are these final and good to go into our mainnet contracts? We're deploying soon |
Hey guys, just thought of an issue with this approach. Since all events will be emitted from our hub chain, there is no way to express the fromChain for the order if we use the InterchainTokenSent event. You will have the toChain in the event, but not know what the fromChain is. If you're assuming the fromChain is the chain where the event is emitted, this will be incorrect. Every order will appear to be coming from our hub chain. Would also be helpful to know what UI this is going to be displayed on. Will each event be on axelarscan as a bridge tx with a fromChain toChain and amount? |
https://axelarnetwork.atlassian.net/browse/AXE-5550