Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(gateway): add a limits section to the integration spec #192

Merged
merged 5 commits into from
Oct 23, 2024
Merged

docs(gateway): add a limits section to the integration spec #192

merged 5 commits into from
Oct 23, 2024

Conversation

milapsheth
Copy link
Member

@milapsheth milapsheth commented Oct 21, 2024 •
edited by jira bot
Loading

@milapsheth milapsheth requested a review from a team as a code owner October 21, 2024 03:09
@milapsheth milapsheth changed the title docs: add a limits section to the integration spec docs(gateway): add a limits section to the integration spec Oct 21, 2024
@codecov-commenter
Copy link

codecov-commenter commented Oct 21, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.66%. Comparing base (2472998) to head (da8d1b4).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #192   +/-   ##
=======================================
  Coverage   98.66%   98.66%           
=======================================
  Files          47       47           
  Lines         747      747           
  Branches      154      154           
=======================================
  Hits          737      737           
  Misses          1        1           
  Partials        9        9

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ahramy
ahramy reviewed Oct 21, 2024
View reviewed changes
contracts/gateway/INTEGRATION.md Outdated Show resolved Hide resolved
contracts/gateway/INTEGRATION.md Outdated Show resolved Hide resolved
contracts/gateway/INTEGRATION.md Show resolved Hide resolved
AttissNgo
AttissNgo reviewed Oct 21, 2024
View reviewed changes
contracts/gateway/INTEGRATION.md Outdated Show resolved Hide resolved
contracts/gateway/INTEGRATION.md Outdated Show resolved Hide resolved
contracts/gateway/INTEGRATION.md Outdated Show resolved Hide resolved
contracts/gateway/INTEGRATION.md Outdated Show resolved Hide resolved
contracts/gateway/INTEGRATION.md Outdated Show resolved Hide resolved
ahramy
ahramy approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@ahramy ahramy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. approved

@milapsheth milapsheth merged commit 9847262 into main Oct 23, 2024
5 checks passed
@milapsheth milapsheth deleted the feat/integration-doc branch October 23, 2024 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AttissNgo AttissNgo AttissNgo left review comments

@ahramy ahramy ahramy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@milapsheth @codecov-commenter @AttissNgo @ahramy