Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow package rename #49

Merged
merged 5 commits into from
Feb 2, 2025
Merged

Follow package rename #49

merged 5 commits into from
Feb 2, 2025

Conversation

michaelblyons
Copy link
Contributor

@michaelblyons michaelblyons commented Jan 27, 2025

@michaelblyons
Copy link
Contributor Author

What did I miss? 🤔

@axemonk
Copy link
Owner

axemonk commented Feb 2, 2025

Is it because the root directory of the repository would then be named "Spreadsheet Formula" or "Spreadsheet-Formula"? Some of the paths (maybe just the ones the bot is using) still assume "Excel formula". See Syntax Tests (latest), step syntax-test-action@v2.

@axemonk
Copy link
Owner

axemonk commented Feb 2, 2025

What the heck I did the thing.

@michaelblyons michaelblyons marked this pull request as ready for review February 2, 2025 21:11
@michaelblyons
Copy link
Contributor Author

Is it because the root directory of the repository would then be named "Spreadsheet Formula"?

Yes. That is literally the point of this PR. I am not sure how some files got past me.

Oh well. Now ready for merge.

@axemonk axemonk merged commit 3b98f8e into axemonk:main Feb 2, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants