MINMAL WIP FUBAR FIX: get Nx lib and Node app working with ESM and "t…

…ype": "module" (albeit with many caveats) 1. You have to physically remove every last vestige of Jest anything (even it just being there in the dir breaks shit) 2. You have to set bundle: true for the app although I guess maybe that is oK 3. You have to enable "allowImportingTsExtensions" which is awesome but will break other shit
axhxrx · Jun 9, 2024 · cf0795b · cf0795b
1 parent 211d073
commit cf0795b
Show file tree

Hide file tree

Showing 9 changed files with 13 additions and 13 deletions.
diff --git a/apps/axhxrx-nx-esm-fuckery/project.json b/apps/axhxrx-nx-esm-fuckery/project.json
@@ -13,7 +13,7 @@
         "platform": "node",
         "outputPath": "dist/apps/axhxrx-nx-esm-fuckery",
         "format": ["esm"],
-        "bundle": false,
+        "bundle": true,
         "main": "apps/axhxrx-nx-esm-fuckery/src/main.ts",
         "tsConfig": "apps/axhxrx-nx-esm-fuckery/tsconfig.app.json",
         "assets": ["apps/axhxrx-nx-esm-fuckery/src/assets"],

diff --git a/apps/axhxrx-nx-esm-fuckery/tsconfig.app.json b/apps/axhxrx-nx-esm-fuckery/tsconfig.app.json
@@ -2,7 +2,6 @@
   "extends": "./tsconfig.json",
   "compilerOptions": {
     "outDir": "../../dist/out-tsc",
-    "module": "commonjs",
     "types": ["node"]
   },
   "exclude": ["jest.config.ts", "src/**/*.spec.ts", "src/**/*.test.ts"],

diff --git a/libs/nx-buildable-esbuild-lib/package.json b/libs/nx-buildable-esbuild-lib/package.json
@@ -2,7 +2,7 @@
   "name": "@local/nx-buildable-esbuild-lib",
   "version": "0.0.1",
   "dependencies": {},
-  "type": "commonjs",
+  "type": "module",
   "main": "./index.cjs",
   "private": true
 }
diff --git a/libs/nx-buildable-esbuild-lib/project.json b/libs/nx-buildable-esbuild-lib/project.json
@@ -13,8 +13,9 @@
         "main": "libs/nx-buildable-esbuild-lib/src/index.ts",
         "tsConfig": "libs/nx-buildable-esbuild-lib/tsconfig.lib.json",
         "assets": ["libs/nx-buildable-esbuild-lib/*.md"],
-        "generatePackageJson": true,
-        "format": ["cjs"]
+        "format": [
+          "esm"
+        ]
       }
     },
     "test": {

diff --git a/libs/nx-buildable-esbuild-lib/src/index.ts b/libs/nx-buildable-esbuild-lib/src/index.ts
@@ -1,3 +1,3 @@
-export * from './lib/nx-buildable-esbuild-lib';
-export * from './lib/Animal';
-export * from './lib/Tarantula';
+export * from './lib/nx-buildable-esbuild-lib.ts';
+export * from './lib/Animal.ts';
+export * from './lib/Tarantula.ts';
diff --git a/libs/nx-buildable-esbuild-lib/src/lib/Tarantula.ts b/libs/nx-buildable-esbuild-lib/src/lib/Tarantula.ts
@@ -1,4 +1,4 @@
-import { Animal } from './Animal';
+import { Animal } from './Animal.ts';
 
 export class Tarantula extends Animal
 {

diff --git a/libs/nx-buildable-esbuild-lib/src/lib/nx-buildable-esbuild-lib.spec.ts b/libs/nx-buildable-esbuild-lib/src/lib/nx-buildable-esbuild-lib.spec.ts
@@ -1,5 +1,5 @@
-import { nxBuildableEsbuildLib } from './nx-buildable-esbuild-lib';
-import { Animal } from './Animal';
+import { nxBuildableEsbuildLib } from './nx-buildable-esbuild-lib.ts';
+import { Animal } from './Animal.ts';
 
 describe('nxBuildableEsbuildLib', () => {
   it('should work', () => {

diff --git a/libs/nx-buildable-esbuild-lib/tsconfig.json b/libs/nx-buildable-esbuild-lib/tsconfig.json
@@ -1,7 +1,6 @@
 {
   "extends": "../../tsconfig.base.json",
   "compilerOptions": {
-    "module": "commonjs",
     "forceConsistentCasingInFileNames": true,
     "strict": true,
     "noImplicitOverride": true,

diff --git a/tsconfig.base.json b/tsconfig.base.json
@@ -4,12 +4,13 @@
     "rootDir": ".",
     "sourceMap": true,
     "declaration": false,
-    "moduleResolution": "node",
+    "moduleResolution": "Bundler",
     "emitDecoratorMetadata": true,
     "experimentalDecorators": true,
     "importHelpers": true,
     "target": "es2015",
     "module": "esnext",
+    "allowImportingTsExtensions": true,
     "lib": ["es2020", "dom"],
     "skipLibCheck": true,
     "skipDefaultLibCheck": true,