feat: check executable path is suitable #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mistydemeo
force-pushed
the
compare_binary_path
branch
from
9af8f27 to
aa80181
Compare
Gankra
approved these changes
Mar 8, 2024
| @@ -122,6 +127,7 @@ impl AxoUpdater { | |||
|
|
|||
| self.source = Some(receipt.source.clone()); | |||
| self.current_version = Some(receipt.version.to_owned()); | |||
| self.install_prefix = Some(receipt.install_prefix.to_owned()); | |||
There was a problem hiding this comment.
heh, NOW it gets used (sorry again for messing it up, nice robust code to work around it... hope no one's foolish enough to make bin/bin/)
There was a problem hiding this comment.
All good! Since we have to do it for the bin path anyway, it's not a big deal to do it in both places
Compare the installation root of the previous version to the location the current executable is being run from. This is now part of the "should an update be performed" check. Fixes #34.
mistydemeo
force-pushed
the
compare_binary_path
branch
from
aa80181 to
f596a26
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compare the installation root of the previous version to the location the current executable is being run from. This is now part of the "should an update be performed" check.
Fixes #34.