Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filterx: stack allocated string followups #491

Merged
merged 2 commits into from
Feb 8, 2025

Conversation

alltilla
Copy link
Member

@alltilla alltilla commented Feb 5, 2025

Followup for #470

Copy link
Member

@bazsi bazsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, I don't understand the first patch entirely.

@alltilla alltilla force-pushed the filterx-stack-string-followups branch from a2ab304 to 734c6a2 Compare February 7, 2025 12:43
@alltilla
Copy link
Member Author

alltilla commented Feb 7, 2025

Rebased to main.

@alltilla
Copy link
Member Author

alltilla commented Feb 7, 2025

@bazsi Can you re-review this please? All the dependency PRs are merged.

@alltilla alltilla requested a review from bazsi February 7, 2025 12:59
@bazsi bazsi merged commit 28d8156 into axoflow:main Feb 8, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants