Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update design_pattern.md #176

Merged
merged 6 commits into from
Jul 20, 2023
Merged

docs: update design_pattern.md #176

merged 6 commits into from
Jul 20, 2023

Conversation

linnnsss
Copy link
Contributor

resize images in design pattern

@linnnsss linnnsss requested a review from a team as a code owner July 17, 2023 07:57
@linnnsss linnnsss requested review from KaoImin and kelisi129 and removed request for a team July 17, 2023 07:57
@vercel
Copy link

vercel bot commented Jul 17, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
axon-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 20, 2023 1:17am

@KaoImin KaoImin changed the title Update design_pattern.md di]Update design_pattern.md Jul 17, 2023
@KaoImin KaoImin changed the title di]Update design_pattern.md docs: update design_pattern.md Jul 17, 2023
linnnsss
linnnsss commented Jul 17, 2023
View reviewed changes
Copy link
Contributor Author

@linnnsss linnnsss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resize format corrected

@linnnsss
Update design_pattern.md
1f9a481 
correct code for image resizing
linnnsss
linnnsss commented Jul 19, 2023
View reviewed changes
Copy link
Contributor Author

@linnnsss linnnsss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correct code again for image resizing

@linnnsss
Update design_pattern.md
3e22638 
use "max height" to resize
linnnsss
linnnsss commented Jul 19, 2023
View reviewed changes
Copy link
Contributor Author

@linnnsss linnnsss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use "max height" to resize

@linnnsss
Update design_pattern.md
96997a2 
replace the image mistaken
linnnsss
linnnsss commented Jul 19, 2023
View reviewed changes
Copy link
Contributor Author

@linnnsss linnnsss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

replace the image mistaken

@linnnsss
Update design_pattern.md
426d32d 
modify code to center align images
linnnsss
linnnsss commented Jul 20, 2023
View reviewed changes
Copy link
Contributor Author

@linnnsss linnnsss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

modify code to center align images

@KaoImin KaoImin merged commit d0df0f1 into axonweb3:main Jul 20, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KaoImin KaoImin KaoImin approved these changes

@kelisi129 kelisi129 Awaiting requested review from kelisi129 kelisi129 is a code owner automatically assigned from axonweb3/axon-content

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@linnnsss @KaoImin