Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid useless conversions #1123

Merged
merged 2 commits into from
Dec 27, 2024
Merged

Conversation

tamird
Copy link
Member

@tamird tamird commented Dec 27, 2024

Use native C types to avoid platform-dependent conversions.


This change is Reviewable

@tamird tamird requested a review from vadorovsky December 27, 2024 14:50
Copy link

netlify bot commented Dec 27, 2024

Deploy Preview for aya-rs-docs failed.

Built without sensitive environment variables

Name Link
🔨 Latest commit 52d0eb3
🔍 Latest deploy log https://app.netlify.com/sites/aya-rs-docs/deploys/676ec11b1ca1b000083b46ba

Copy link

mergify bot commented Dec 27, 2024

Hey @alessandrod, this pull request changes the Aya Public API and requires your review.

@mergify mergify bot added the api/needs-review Makes an API change that needs review label Dec 27, 2024
@mergify mergify bot requested a review from alessandrod December 27, 2024 14:50
@mergify mergify bot added aya This is about aya (userspace) test A PR that improves test cases or CI labels Dec 27, 2024
Use native C types to avoid platform-dependent conversions.
@tamird tamird force-pushed the avoid-useless-conversions branch from fa9a6f2 to 52d0eb3 Compare December 27, 2024 15:00
@tamird tamird merged commit 78ee9a4 into aya-rs:main Dec 27, 2024
23 checks passed
@tamird tamird deleted the avoid-useless-conversions branch December 27, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api/needs-review Makes an API change that needs review aya This is about aya (userspace) test A PR that improves test cases or CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants