aya/maps: pin for (async)perf_event_array

[astoycos]

Implement pinning for perf_event_array and async_perf_event_array. Additionally make the core MapData.pin method operate on a reference rather than a mutable reference.

TODO from #783

[netlify]

✅ Deploy Preview for aya-rs-docs ready!

Built without sensitive environment variables

Name	Link
🔨 Latest commit	263bcb2
🔍 Latest deploy log	https://app.netlify.com/sites/aya-rs-docs/deploys/6565f8ea632e7100088e9072
😎 Deploy Preview	https://deploy-preview-822--aya-rs-docs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[mergify]

Hey @alessandrod, this pull request changes the Aya Public API and requires your review.

[mergify]

@astoycos, this pull request is now in conflict and requires a rebase.

[tamird]

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @alessandrod and @astoycos)

---

aya/src/maps/perf/async_perf_event_array.rs line 116 at r1 (raw file):

    /// When a map is pinned it will remain loaded until the corresponding file
    /// is deleted. All parent directories in the given `path` must already exist.
    pub fn pin<P: AsRef<Path>>(&mut self, path: P) -> Result<(), PinError> {

shouldn't this take &self?

---

aya/src/maps/perf/perf_event_array.rs line 206 at r1 (raw file):

    /// When a map is pinned it will remain loaded until the corresponding file
    /// is deleted. All parent directories in the given `path` must already exist.
    pub fn pin<P: AsRef<Path>>(&mut self, path: P) -> Result<(), PinError> {

shouldn't this take &self?

[tamird]

Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @alessandrod and @astoycos)

---

aya/src/maps/perf/perf_event_array.rs line 7 at r1 (raw file):

    borrow::{Borrow, BorrowMut},
    ops::Deref,
    os::fd::{AsFd as _, AsRawFd, BorrowedFd, RawFd},

this as _ is incorrect conflict resolution

[astoycos]

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @alessandrod and @astoycos)

aya/src/maps/perf/async_perf_event_array.rs line 116 at r1 (raw file):

    /// When a map is pinned it will remain loaded until the corresponding file
    /// is deleted. All parent directories in the given `path` must already exist.
    pub fn pin<P: AsRef<Path>>(&mut self, path: P) -> Result<(), PinError> {

shouldn't this take &self?

aya/src/maps/perf/perf_event_array.rs line 206 at r1 (raw file):

    /// When a map is pinned it will remain loaded until the corresponding file
    /// is deleted. All parent directories in the given `path` must already exist.
    pub fn pin<P: AsRef<Path>>(&mut self, path: P) -> Result<(), PinError> {

shouldn't this take &self?

Done, good catch thanks!

[tamird]

Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @alessandrod)

[mergify]

@astoycos, this pull request is now in conflict and requires a rebase.

[tamird]

Reviewed 3 of 3 files at r3, all commit messages.
Dismissed @alessandrod from 2 discussions.
Reviewable status: complete! all files reviewed, all discussions resolved