aya: make KernelVersion::code public #836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for aya-rs-docs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Hey @alessandrod, this pull request changes the Aya Public API and requires your review. |
mergify
bot
added
api/needs-review
astoycos
approved these changes
Nov 16, 2023
There was a problem hiding this comment.
current() is already public I don't see any reason exposing code() is an issue 👍
Just need @alessandrod Because of the API change, thanks!
alessandrod
approved these changes
Nov 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need to be able to access the current kernel version code so I can make some decisions in user space and/or send the information to the eBPF programs to make the decisions.
I could re-implement the logic to get the kernel version myself but since
ayaalready has all the logic and is well tested I figured it made the most sense to expose the method I had previously implemented here. Another alternative would be to expose the fields insideKernelVersionbut that felt like a bigger surface area to guarantee no breaking changes rather than just the one method.Maybe in the future we should implement the
__kconfigstuff that libbpf and cilium allow so that the eBPF programs will know theKERNEL_VERSION_CODEbut that felt heavyweight to implement at the moment and I wasn't sure if CO-RE was required for it which my current programs do not support.