Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

public-api: regenerate #862

Merged
merged 1 commit into from
Jan 8, 2024
Merged

public-api: regenerate #862

merged 1 commit into from
Jan 8, 2024

Conversation

tamird
Copy link
Member

@tamird tamird commented Jan 7, 2024

Send + Sync became Sync + Send for reasons I don't understand.

`Send + Sync` became `Sync + Send` for reasons I don't understand.
Copy link

netlify bot commented Jan 7, 2024

Deploy Preview for aya-rs-docs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 1edd42a
🔍 Latest deploy log https://app.netlify.com/sites/aya-rs-docs/deploys/659ad4b96d18c300081a0204
😎 Deploy Preview https://deploy-preview-862--aya-rs-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

mergify bot commented Jan 7, 2024

Hey @alessandrod, this pull request changes the Aya Public API and requires your review.

@mergify mergify bot requested a review from alessandrod January 7, 2024 16:44
@mergify mergify bot added api/needs-review Makes an API change that needs review test A PR that improves test cases or CI labels Jan 7, 2024
@alessandrod
Copy link
Collaborator

Why is this needed? Locally I don't seem to get Sync + Send

@tamird
Copy link
Member Author

tamird commented Jan 7, 2024

Did you try with today's nightly?

@tamird
Copy link
Member Author

tamird commented Jan 8, 2024

@tamird tamird merged commit 53df49e into aya-rs:main Jan 8, 2024
21 checks passed
@tamird tamird deleted the update-api branch January 8, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api/needs-review Makes an API change that needs review test A PR that improves test cases or CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants