Enable fatal errors by default

Add #![no_builtins] to all test programs; see aya-rs/aya#698 for rationale.
aya-rs · Jul 27, 2023 · 99a3623 · 99a3623
1 parent 92b7410
commit 99a3623
Show file tree

Hide file tree

Showing 6 changed files with 6 additions and 6 deletions.
diff --git a/src/bin/bpf-linker.rs b/src/bin/bpf-linker.rs
@@ -141,7 +141,7 @@ struct CommandLine {
     export: Vec<String>,
 
     /// Whether to treat LLVM errors as fatal.
-    #[clap(long, action = clap::ArgAction::Set, default_value_t = false)]
+    #[clap(long, action = clap::ArgAction::Set, default_value_t = true)]
     fatal_errors: bool,
 
     // The options below are for wasm-ld compatibility

diff --git a/tests/assembly/auxiliary/dep.rs b/tests/assembly/auxiliary/dep.rs
@@ -5,4 +5,4 @@
 #[no_mangle]
 fn some_dep() -> u8 {
     42
-}
+}
diff --git a/tests/assembly/auxiliary/loop-panic-handler.rs b/tests/assembly/auxiliary/loop-panic-handler.rs
@@ -6,4 +6,3 @@
 fn panic_impl(_: &core::panic::PanicInfo) -> ! {
     loop {}
 }
-
diff --git a/tests/assembly/bin.rs b/tests/assembly/bin.rs
@@ -3,8 +3,9 @@
 
 // Same as bpf-sections.rs, but using bin as crate-type.
 
-#![no_std]
+#![no_builtins]
 #![no_main]
+#![no_std]
 
 // aux-build: loop-panic-handler.rs
 extern crate loop_panic_handler;

diff --git a/tests/assembly/elf-sections.rs b/tests/assembly/elf-sections.rs
@@ -22,4 +22,4 @@ static mut COUNTER: u32 = 0;
 
 // CHECK: .section "uprobe/connect","ax"
 // CHECK: .section "uprobe/dep","ax"
-// CHECK: .section "maps/counter","aw"
+// CHECK: .section "maps/counter","aw"
diff --git a/tests/assembly/re-export-symbols.rs b/tests/assembly/re-export-symbols.rs
@@ -15,4 +15,4 @@ fn connect() {
 }
 
 // CHECK: .globl connect
-// CHECK: .globl some_dep
+// CHECK: .globl some_dep
-Original file line number
+Diff line change
@@ Expand Up / @@ -5,4 +5,4 @@ @@
     #[no_mangle]
     fn some_dep() -> u8 {
-    }
+    }
Original file line number	Diff line number	Diff line change
Expand Up		@@ -6,4 +6,3 @@
		fn panic_impl(_: &core::panic::PanicInfo) -> ! {
		loop {}
		}