Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove LearnerPipeline and LearnerPipelineConfig #2056

Merged
merged 2 commits into from
Feb 8, 2024

Conversation

AdeelH
Copy link
Collaborator

@AdeelH AdeelH commented Feb 7, 2024

Overview

This PR removes

  • the legacy/unused LearnerPipeline and
  • the LearnerPipelineConfig which was only used to wrap the LearnerConfig for saving it in the model bundle.

Other changes:

  • The model bundles now store the LearnerConfig directly.
  • The Config upgradation functionality which was previously limited to PipelineConfigs has been extended to all Configs.
  • The ability to deserialize LearnerPipelineConfigs has been retained for backward compatibility.

Checklist

  • Added unit tests, if applicable
  • Updated documentation, if applicable
  • Added needs-backport label if the change should be back-ported to the previous release
  • PR has a name that won't get you publicly shamed for vagueness

Notes

Backward compatibility with older model bundles has been maintained.

Testing Instructions

See new/updated unit tests.


Also related to #965

- Define Config.to_file() that can serialize with RV metadata, like plugin versions, attached.
- Define Config.from_file() to deserialize and upgrade if RV metadata found.
@AdeelH AdeelH force-pushed the learner-bundle-config branch from 7cb22e7 to 9ad0072 Compare February 8, 2024 14:41
@AdeelH AdeelH force-pushed the learner-bundle-config branch from 9ad0072 to e67e488 Compare February 8, 2024 14:56
Copy link

codecov bot commented Feb 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9fd4dd5) 89.58% compared to head (e67e488) 89.68%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2056      +/-   ##
==========================================
+ Coverage   89.58%   89.68%   +0.09%     
==========================================
  Files         198      196       -2     
  Lines        9720     9723       +3     
==========================================
+ Hits         8708     8720      +12     
+ Misses       1012     1003       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AdeelH AdeelH marked this pull request as ready for review February 8, 2024 18:44
@AdeelH AdeelH merged commit 44891f0 into azavea:master Feb 8, 2024
2 checks passed
@AdeelH AdeelH deleted the learner-bundle-config branch February 8, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant