Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handing of some edge cases when reading chips from XarraySource #2058

Merged
merged 3 commits into from
Feb 12, 2024

Conversation

AdeelH
Copy link
Collaborator

@AdeelH AdeelH commented Feb 9, 2024

Overview

This PR ensures that XarraySource._get_chip(window) always returns a chip of the same size as the window, even if the window is not fully or partially contained within the XarraySource's bbox. It also handles the subtle case of the user-specified bbox overflowing the full extent of the DataArray.

Checklist

  • Added unit tests, if applicable
  • Updated documentation, if applicable
  • Added needs-backport label if the change should be back-ported to the previous release
  • PR has a name that won't get you publicly shamed for vagueness

Notes

N/A

Testing Instructions

  • See new unit tests.

Copy link

codecov bot commented Feb 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2359be1) 89.69% compared to head (dd2562c) 89.69%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2058   +/-   ##
=======================================
  Coverage   89.69%   89.69%           
=======================================
  Files         196      196           
  Lines        9731     9735    +4     
=======================================
+ Hits         8728     8732    +4     
  Misses       1003     1003           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AdeelH AdeelH marked this pull request as ready for review February 12, 2024 14:58
@AdeelH AdeelH merged commit cf95e94 into azavea:master Feb 12, 2024
2 checks passed
@AdeelH AdeelH deleted the fix-xr branch February 12, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant