Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ccm] Use clusterName in generated cloud-config #11

Open
wants to merge 1 commit into
base: feature/addon-provider
Choose a base branch
from
Open

[ccm] Use clusterName in generated cloud-config #11

wants to merge 1 commit into from

Conversation

yankcrime
Copy link
Contributor

If the entry in the cloud-config file doesn't match the name of the cluster, then CCM fails to start and throws an error. To fix this, we use clusterName if specified, otherwise fall back to the previous default of openstack.

@yankcrime
[ccm] Use clusterName in generated cloud-config
288f59b 
If the entry in the cloud-config file doesn't match the name of the
cluster, then CCM fails to start and throws an error.  To fix this, we
use clusterName if specified, otherwise fall back to the previous
default of `openstack`.
@mkjpryor
Copy link
Collaborator

mkjpryor commented Nov 2, 2022 •
edited
Loading

@yankcrime

I don't think .Values.clusterName is the right thing to use here. It is intended to match the actual name of the Cluster API cluster and is passed to the OCCM/CSI Cinder to allow it to tag OS resources as belonging to the cluster. This needs to work even if every credential uses openstack in the clouds.yaml.

I think we need a new field under .Values.openstack, e.g. .Values.openstack.cloudName, that can be used to control the name that is referred to by the clouds.yaml.

@mkjpryor mkjpryor self-requested a review November 2, 2022 11:42
mkjpryor
mkjpryor requested changes Nov 2, 2022
View reviewed changes
Copy link
Collaborator

@mkjpryor mkjpryor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment https://github.com/stackhpc/capi-helm-charts/pull/11#issuecomment-1300176216

@yankcrime
Copy link
Contributor Author

I think I conflated a couple of things here since we're using a different Helm chart to deploy our clusters and I completely overlooked where this value originally came from.

I do think this should be configurable in this Helm chart though and not hardcoded as openstack, so I'll update this PR with your suggestion 👍

@scrungus scrungus requested a review from mkjpryor December 21, 2022 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkjpryor mkjpryor Awaiting requested review from mkjpryor

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yankcrime @mkjpryor