-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dnsNameservers context to pick up values #477
base: main
Are you sure you want to change the base?
Conversation
@mkjpryor If there is a better approach here than removing the context change It would be nice to move the |
I was also thinking that the fix here should probably be to move the values field into In order to maintain backwards compatibility, I think we just have to replace
with
and modify |
67d97d0
to
c8d21ba
Compare
Ah thanks, @mkjpryor - that was a lot easier than what I was thinking of. I wasn't sure of the best practice around referencing values outside the current scope. Updated the PR to use your suggestion and moved the values field. |
Move dnsNameservers from .Values.clusterNetworking to .Values.clusterNetworking.internalNetwork to better reflect where it is used within OpenStackCluster now. Backwards compatibility with the former values location is kept and a bug fixed to correctly reference this. This use is now deprecated and may be removed in a future chart release. Closes: azimuth-cloud#476
c8d21ba
to
0d45740
Compare
The
dnsNameservers
value has moved intomanagedSubnets
section, but was trying to reference.internalNetwork.dnsNameservers
which does not exist in chart values.This change removes the context switch into
internalNetwork
to allow all references to correctly find their related values.Closes: #476