Update OpenStackCluster with v1beta1 case and omitempty. #481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These changes match resource changes in CAPO and allow tools such as ArgoCD to fully synchronize the resource instead of showing minor changes. No functionality is changed. * disableAPIServerFloatingIP is now `omitempty`[1], and is therefore absent when querying the resource when set to 'false'. * `allowedCidrs` becomes `allowedCIDRs` [2] [1] kubernetes-sigs/cluster-api-provider-openstack@9223883 [2] https://cluster-api-openstack.sigs.k8s.io/topics/crd-changes/v1alpha7-to-v1beta1#changes-to-ports
mkjpryor
requested changes
Jan 27, 2025
There was a problem hiding this comment.
Looks like this caused the chart upgrade test to fail, which tests upgrading the chart while keeping the same values. This is because the OpenStackCluster.spec changes, even though it is effectively a null change (which does annoy me...). I suspect the issue is the disableAPIServerFloatingIP change, and I'm not sure how we fix it.
FWIW, the charts as they are cause us no issues with Flux. I'm inclined not to break on chart upgrade for the sake of one tool right now...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes match resource changes in CAPO and allow tools such as ArgoCD to fully synchronize the resource instead of showing minor changes. No functionality is changed.
omitempty[1], and is therefore absent when querying the resource when set to 'false'.allowedCidrsbecomesallowedCIDRs[2][1] kubernetes-sigs/cluster-api-provider-openstack@9223883
[2] https://cluster-api-openstack.sigs.k8s.io/topics/crd-changes/v1alpha7-to-v1beta1#changes-to-ports