-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct slugs according to caf recommended abbreviations #188
base: 3_0
Are you sure you want to change the base?
Conversation
Very good catches @t3mi - we will add it on next major update to avoid regression on already deployed resources! |
Kudos, SonarCloud Quality Gate passed! |
Yeah, I've targeted |
@arnaudlh , could this be part of the 2.0 release? Maybe generating a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (2)
- azurecaf/internal/models/models_generated.go: File too large
- resourceDefinition.json: Language not supported
Tip: Turn on automatic Copilot reviews for this repository to get quick feedback on every pull request. Learn more
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Tip: Copilot only keeps its highest confidence comments to reduce noise and keep you focused. Learn more
Fixes #186, #168
PR Checklist
resourceDefinition.json
models_generated.go
file in my PR)Description
Does this introduce a breaking change
Testing