Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct slugs according to caf recommended abbreviations #188

Open
wants to merge 1 commit into
base: 3_0
Choose a base branch
from

Conversation

t3mi
Copy link
Contributor

@t3mi t3mi commented Sep 6, 2022

Fixes #186, #168

PR Checklist


  • I have read the CONTRIBUTING.MD instructions
  • I have changed the resourceDefinition.json
  • I have generated the resource model (there's a models_generated.go file in my PR)
  • I have updated the README.md#resource-status
  • I have checked to ensure there aren't other open Pull Requests for the same update/change?

Description

Does this introduce a breaking change

  • YES
  • NO

Testing

@arnaudlh
Copy link
Member

Very good catches @t3mi - we will add it on next major update to avoid regression on already deployed resources!

@arnaudlh arnaudlh closed this Sep 28, 2022
@arnaudlh arnaudlh reopened this Sep 28, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@arnaudlh arnaudlh added the enhancement New feature or request label Sep 28, 2022
@arnaudlh arnaudlh changed the title correct slugs according to caf recommended abbreviations Correct slugs according to caf recommended abbreviations Sep 28, 2022
@t3mi
Copy link
Contributor Author

t3mi commented Sep 28, 2022

Yeah, I've targeted 3_0 branch for the merge. If this isn't right please provide the correct target. Thanks!

@carnei-ro
Copy link

@arnaudlh , could this be part of the 2.0 release? Maybe generating a -preview4; I am considering using this provider, but I'd like to start CAF compliant

@arnaudlh arnaudlh requested a review from Copilot December 2, 2024 09:12

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (2)
  • azurecaf/internal/models/models_generated.go: File too large
  • resourceDefinition.json: Language not supported

Tip: Turn on automatic Copilot reviews for this repository to get quick feedback on every pull request. Learn more

@arnaudlh arnaudlh requested a review from Copilot January 28, 2025 09:18

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

Tip: Copilot only keeps its highest confidence comments to reduce noise and keep you focused. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Status: 👀 In review
Development

Successfully merging this pull request may close these issues.

[Bug]: Route Table is not CAF aligned [Bug Report]: FunctionApp is not CAF aligned
4 participants