Skip to content

Commit

Permalink
disable upgrade flag added
Browse files Browse the repository at this point in the history
  • Loading branch information
sachinkum0009 authored Aug 29, 2024
1 parent 4d8427f commit 5d1a53e
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 1 deletion.
11 changes: 10 additions & 1 deletion rtwcli/rtw_cmds/rtw_cmds/workspace/create_verb.py
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,7 @@ class CreateVerbArgs:
repos_no_skip_existing: bool = False
disable_nvidia: bool = False
docker: bool = False
disable_upgrade: bool = False

@property
def ws_name(self) -> str:
Expand Down Expand Up @@ -385,6 +386,14 @@ def add_arguments(self, parser: argparse.ArgumentParser, cli_name: str):
help="Disable nvidia rocker flag",
default=False,
)
parser.add_argument(
"--disable-upgrade",
action="store_true",
help="Disable upgrade flag",
default=False,
)


parser.add_argument(
"--ws-repos-file-name",
type=str,
Expand Down Expand Up @@ -601,7 +610,7 @@ def generate_intermediate_dockerfile_content(self, create_args: CreateVerbArgs)
return textwrap.dedent(
f"""
FROM {create_args.base_image_name}
RUN apt-get update && apt-get upgrade -y
RUN apt-get update {"&& apt-get upgrade -y" if not create_args.disable_upgrade else ""}
{apt_packages_cmd}
{python_packages_cmd}
{rtw_clone_cmd}
Expand Down
8 changes: 8 additions & 0 deletions rtwcli/rtw_cmds/rtw_cmds/workspace/import_verb.py
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ class ImportVerbArgs:
standalone_docker_image: str
docker: bool = True
disable_nvidia: bool = False
disable_upgrade: bool = False
standalone: bool = True
final_image_name: str = ""
container_name: str = ""
Expand Down Expand Up @@ -88,6 +89,12 @@ def add_arguments(self, parser: argparse.ArgumentParser, cli_name: str):
help="Disable nvidia rocker flag",
default=False,
)
parser.add_argument(
"--disable-upgrade",
action="store_true",
help="Disable upgrade flag",
default=False,
)
parser.add_argument(
"--final-image-name",
type=str,
Expand Down Expand Up @@ -134,6 +141,7 @@ def main(self, *, args):
import_args = ImportVerbArgs(**filtered_args)
rocker_flags = generate_rocker_flags(
disable_nvidia=import_args.disable_nvidia,
disable_upgrade=import_args.disable_upgrade,
container_name=import_args.container_name,
hostname=import_args.hostname,
ssh_abs_path=import_args.ssh_abs_path,
Expand Down

0 comments on commit 5d1a53e

Please sign in to comment.