Skip to content

Commit

Permalink
Add Flag to Disable Automatic Upgrades in Script (#233)
Browse files Browse the repository at this point in the history
* disable upgrade flag added

* style: fix E303 by removing extra blank lines in create_verb.py

* Remove mistakenly added disable_upgrade parameter from generate_rocker_flags

* ⚡ removed disable upgrade flag from import verb

* remove disable upgrade flag from import

* Update rtwcli/rtw_cmds/rtw_cmds/workspace/create_verb.py

---------

Co-authored-by: Manuel Muth <[email protected]>
  • Loading branch information
sachinkum0009 and mamueluth authored Sep 3, 2024
1 parent 4d8427f commit 754f3fa
Showing 1 changed file with 8 additions and 1 deletion.
9 changes: 8 additions & 1 deletion rtwcli/rtw_cmds/rtw_cmds/workspace/create_verb.py
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,7 @@ class CreateVerbArgs:
repos_no_skip_existing: bool = False
disable_nvidia: bool = False
docker: bool = False
disable_upgrade: bool = False

@property
def ws_name(self) -> str:
Expand Down Expand Up @@ -385,6 +386,12 @@ def add_arguments(self, parser: argparse.ArgumentParser, cli_name: str):
help="Disable nvidia rocker flag",
default=False,
)
parser.add_argument(
"--disable-upgrade",
action="store_true",
help="Disable execution of 'apt-get upgrade' when creating workspace.",
default=False,
)
parser.add_argument(
"--ws-repos-file-name",
type=str,
Expand Down Expand Up @@ -601,7 +608,7 @@ def generate_intermediate_dockerfile_content(self, create_args: CreateVerbArgs)
return textwrap.dedent(
f"""
FROM {create_args.base_image_name}
RUN apt-get update && apt-get upgrade -y
RUN apt-get update {"&& apt-get upgrade -y" if not create_args.disable_upgrade else ""}
{apt_packages_cmd}
{python_packages_cmd}
{rtw_clone_cmd}
Expand Down

0 comments on commit 754f3fa

Please sign in to comment.