[rtwcli] add rtw workspace delete #147
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is in conflict. Could you fix it @muritane? |
destogl
reviewed
Aug 17, 2023
| f"Failed to delete docker image '{docker_tag}'. Error:\n{e.output.decode('utf-8')}" | ||
| ) | ||
|
|
||
| def handle_delete_workspaces( |
There was a problem hiding this comment.
Can we ask if we should delete "src" folder please?
destogl
reviewed
Aug 17, 2023
| ] | ||
| self.handle_delete_workspaces(ws_names_to_delete, workspaces_config) | ||
|
|
||
| def delete_docker_image(self, docker_tag: str) -> None: |
There was a problem hiding this comment.
We should also delete docker containers related to workspace.
muritane
force-pushed
the
rtw_workspace_delete
branch
from
599c674 to
19937fd
Compare
|
This pull request is in conflict. Could you fix it @muritane? |
|
this branch is outdated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.