dllama-api: /v1/models: return basename of the model #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the /v1/models api endpoint to return the basename of the model path instead of the hardcoded value "dl".
|
Great! Thanks! Noticed that this implementation would create an invalid json if the file name would contains any quotation marks. I fixed it here. |
|
Yeah.. that looks a lot more reasonable. Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the
/v1/modelsapi endpoint to return the basename of the model path instead of the hardcoded value"dl".Successfully tested with Open WebUI. Makes identifying the current model in use a little easier.
This works, but my C++ knowledge is a little limited. So this can be taken as a more detailed feature request instead :)