Merge pull request #9 from Menduist/checkedexceptions

Checked exceptions
ba0f3 · Jan 4, 2022 · 1940dee · 1940dee
2 parents 536cc6b + 4389ebf
commit 1940dee
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/dnsclientpkg/records/soa.nim b/src/dnsclientpkg/records/soa.nim
@@ -7,7 +7,7 @@ type SOARecord* = ref object of ResourceRecord
   expire*: int32
   minimum*: uint32
 
-method toString*(r: SOARecord): string = "$# $# $# $# $# $# $#" % [r.mname, r.rname, $r.serial, $r.refresh, $r.retry, $r.expire, $r.minimum]
+method toString*(r: SOARecord): string = [r.mname, r.rname, $r.serial, $r.refresh, $r.retry, $r.expire, $r.minimum].join(" ")
 
 method parse*(r: SOARecord, data: StringStream) =
   r.mname = data.getName()

diff --git a/src/dnsclientpkg/types.nim b/src/dnsclientpkg/types.nim
@@ -106,8 +106,8 @@ type
 
 
 
-method parse*(r: ResourceRecord, data: StringStream) {.base.} =
+method parse*(r: ResourceRecord, data: StringStream) {.base, raises: [Defect, OSError, IOError].} =
   raise newException(LibraryError, "parser for " & $r.kind & " is not implemented yet")
 
-method toString*(r: ResourceRecord): string {.base.} =
-  raise newException(LibraryError, "to override!")
+method toString*(r: ResourceRecord): string {.base, raises: [Defect, OSError, IOError].} =
+  raise newException(LibraryError, "to override!")