-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add prepare statement #57
base: master
Are you sure you want to change the base?
Conversation
0d1b05e
to
cf891f0
Compare
Thanks, I'll check if I can fix CI prior to merging this PR |
Can you merge with master? |
9f19c37
to
c477fc0
Compare
@sunng87 I think prepared statements should be saved in the pod side similar to connections. |
Sorry for disturb I thought bb's sql api is same with next.jdbc but it's slightly different. I will find an environment to test my implementation locally later. |
@sunng87 You can test it locally with a JVM version using this:
|
Thank you @borkdude, after some experiments I realized this is a little more complex than my thought. Yes as you said we need to cache prepared statement because it cannot be serialized via transit. I will need some time to think about how to manage its lifecycle and provide unstandable api. |
This patch brings
next.jdbc/prepare
to babshka-sql-pods