Fix #46: query params are double encoded

babashka · Feb 10, 2024 · 948327d · 948327d
1 parent f8ac15a
commit 948327d
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/src/babashka/http_client/interceptors.clj b/src/babashka/http_client/interceptors.clj
@@ -86,7 +86,10 @@
                                      (url-encode (str v)))) (next kvs))))
       (str/join "&" (persistent! params*)))))
 
-(defn uri-with-query [^java.net.URI uri new-query]
+(defn uri-with-query
+  "We can't use the URI constructor because it encodes all arguments for us.
+  See https://stackoverflow.com/a/77971448/6264"
+  [^java.net.URI uri new-query]
   (let [old-query (.getQuery uri)
         new-query (if old-query (str old-query "&" new-query)
                       new-query)]