Remove @octokit/core dependency #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We shouldn't have to do this: Using github.getOctokit from @actions/github directly instead of using its dependency, @octokit/core, would be preferable here. But it turns out getOctokit cannot be used with the paginateGraphql plugin, despite actions/toolkit#1181 (I couldn't get it to work).
jansiwy
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found this: octokit/core.js#666 (comment)
Merging this will close the broken Dependabot PR, #74.
However, simply removing it from
package.jsondoes not work – ESLint will complain about extraneous dependencies. I also explored other options (like avoidingimport '@octokit/coreand using the GitHub client provided by@actions/github– see 80c3e6c for details)