fix slashed event

internal/db/delegation.go

@@ -4,7 +4,8 @@ import (
 	"context"
 	"errors"
 	"fmt"
-	"log"
+
+	"github.com/rs/zerolog/log"
 
 	"github.com/babylonlabs-io/babylon-staking-indexer/internal/db/model"
 	"github.com/babylonlabs-io/babylon-staking-indexer/internal/types"
@@ -182,10 +183,23 @@ func (db *Database) GetBTCDelegationByStakingTxHash(
 func (db *Database) UpdateDelegationsStateByFinalityProvider(
 	ctx context.Context,
 	fpBTCPKHex string,
+	qualifiedPreviousStates []types.DelegationState,
 	newState types.DelegationState,
 ) error {
+	if len(qualifiedPreviousStates) == 0 {
+		return fmt.Errorf("qualified previous states array cannot be empty")
+	}
+
+	// Convert states to strings
+	qualifiedStateStrs := make([]string, len(qualifiedPreviousStates))
+	for i, state := range qualifiedPreviousStates {
+		qualifiedStateStrs[i] = state.String()
+	}
+
+	// Build filter with both FP and qualified states
 	filter := bson.M{
 		"finality_provider_btc_pks_hex": fpBTCPKHex,
+		"state":                         bson.M{"$in": qualifiedStateStrs},
 	}
 
 	update := bson.M{
@@ -201,11 +215,13 @@ func (db *Database) UpdateDelegationsStateByFinalityProvider(
 		return fmt.Errorf("failed to update delegations: %w", err)
 	}
 
-	log.Printf("Updated %d delegations for finality provider %s to state %s",
-		result.ModifiedCount,
-		fpBTCPKHex,
-		newState.String(),
-	)
+	log.Debug().
+		Str("finality_provider", fpBTCPKHex).
+		Strs("qualified_states", qualifiedStateStrs).
+		Str("new_state", newState.String()).
+		Int64("modified_count", result.ModifiedCount).
+		Msg("Updated delegations for finality provider")
+
 	return nil
 }
 

internal/db/interface.go

@@ -147,12 +147,15 @@ type DbInterface interface {
 	 * UpdateDelegationsStateByFinalityProvider updates the BTC delegation state by the finality provider public key.
 	 * @param ctx The context
 	 * @param fpBtcPkHex The finality provider public key
+	 * @param qualifiedPreviousStates The qualified previous states
 	 * @param newState The new state
-	 * @param qualifiedStates The qualified states
 	 * @return An error if the operation failed
 	 */
 	UpdateDelegationsStateByFinalityProvider(
-		ctx context.Context, fpBtcPkHex string, newState types.DelegationState,
+		ctx context.Context,
+		fpBtcPkHex string,
+		qualifiedPreviousStates []types.DelegationState,
+		newState types.DelegationState,
 	) error
 	/**
 	 * GetDelegationsByFinalityProvider retrieves the BTC delegations by the finality provider public key.

internal/services/delegation.go

@@ -9,6 +9,7 @@ import (
 	"github.com/babylonlabs-io/babylon-staking-indexer/internal/db"
 	"github.com/babylonlabs-io/babylon-staking-indexer/internal/db/model"
 	"github.com/babylonlabs-io/babylon-staking-indexer/internal/types"
+	"github.com/babylonlabs-io/babylon-staking-indexer/internal/utils"
 	bbntypes "github.com/babylonlabs-io/babylon/x/btcstaking/types"
 	ftypes "github.com/babylonlabs-io/babylon/x/finality/types"
 	abcitypes "github.com/cometbft/cometbft/abci/types"
@@ -493,7 +494,7 @@ func (s *Service) processSlashedFinalityProviderEvent(
 	fpBTCPKHex := evidence.FpBtcPk.MarshalHex()
 
 	if dbErr := s.db.UpdateDelegationsStateByFinalityProvider(
-		ctx, fpBTCPKHex, types.StateSlashed,
+		ctx, fpBTCPKHex, types.QualifiedStatesForSlashedDelegation(), types.StateSlashed,
 	); dbErr != nil {
 		return types.NewError(
 			http.StatusInternalServerError,
@@ -513,13 +514,28 @@ func (s *Service) processSlashedFinalityProviderEvent(
 
 	for _, delegation := range delegations {
 		if !delegation.HasInclusionProof() {
+			// If the delegation was never active/has no inclusion proof
+			// no need to emit the event, as it doesn't contribute to stats
 			log.Debug().
 				Str("staking_tx", delegation.StakingTxHashHex).
+				Str("event_type", EventSlashedFinalityProvider.String()).
+				Str("current_state", delegation.State.String()).
 				Str("reason", "missing_inclusion_proof").
 				Msg("skipping slashed delegation event")
 			continue
 		}
 
+		if !utils.Contains(types.QualifiedStatesForSlashedDelegation(), delegation.State) {
+			// If the current state is not qualified, no need to emit the event
+			log.Debug().
+				Str("staking_tx", delegation.StakingTxHashHex).
+				Str("event_type", EventSlashedFinalityProvider.String()).
+				Str("current_state", delegation.State.String()).
+				Str("reason", "not_qualified").
+				Msg("skipped slashed delegation event")
+			continue
+		}
+
 		if err := s.emitUnbondingDelegationEvent(ctx, delegation); err != nil {
 			return err
 		}

internal/services/events.go

@@ -330,7 +330,7 @@ func (s *Service) validateBTCDelegationUnbondedEarlyEvent(ctx context.Context, e
 	if utils.Contains(types.OutdatedStatesForUnbondedEarly(), delegation.State) {
 		log.Debug().
 			Str("stakingTxHashHex", event.StakingTxHash).
-			Str("currentState", event.NewState).
+			Str("currentState", delegation.State.String()).
 			Str("event_type", "EventBTCDelgationUnbondedEarly").
 			Msg("Current state is outdated for transition")
 		return false, true, nil
@@ -387,7 +387,7 @@ func (s *Service) validateBTCDelegationExpiredEvent(ctx context.Context, event *
 	if utils.Contains(types.OutdatedStatesForExpired(), delegation.State) {
 		log.Debug().
 			Str("stakingTxHashHex", event.StakingTxHash).
-			Str("currentState", event.NewState).
+			Str("currentState", delegation.State.String()).
 			Str("event_type", "EventBTCDelegationExpired").
 			Msg("Current state is outdated for transition")
 		return false, true, nil

internal/types/state.go

@@ -61,6 +61,11 @@ func OutdatedStatesForExpired() []DelegationState {
 	return []DelegationState{StateUnbonding, StateWithdrawable, StateWithdrawn}
 }
 
+// QualifiedStatesForSlashedDelegation returns the qualified current states when a delegation is slashed
+func QualifiedStatesForSlashedDelegation() []DelegationState {
+	return []DelegationState{StatePending, StateVerified, StateActive, StateUnbonding, StateWithdrawable}
+}
+
 // QualifiedStatesForWithdrawn returns the qualified current states for Withdrawn event
 func QualifiedStatesForWithdrawn() []DelegationState {
 	// StateActive/StateUnbonding/StateSlashed is included b/c its possible that expiry checker