feat: consume finality provider event #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gitferry
approved these changes
Oct 11, 2024
| @@ -3,7 +3,7 @@ module github.com/babylonlabs-io/babylon-staking-indexer | |||
| go 1.23.2 | |||
|
|
|||
| require ( | |||
| github.com/babylonlabs-io/babylon v0.11.0 | |||
| github.com/babylonlabs-io/babylon v0.12.0 | |||
There was a problem hiding this comment.
can change to babylonlabs-io/babylon@86f6bc5 which includes format change
There was a problem hiding this comment.
@gitferry Require BBN bump to newer version first. Since this repo is WIP as well. I'm not in a hurry to use commit based, we can wait for BBN till released a newer version
| if err != nil { | ||
| return err | ||
| } | ||
| if res.MatchedCount == 0 { |
There was a problem hiding this comment.
seems strange to check this for object not found
There was a problem hiding this comment.
this is the response type from the UpdateOne method
// UpdateResult is the result type returned from UpdateOne, UpdateMany, and ReplaceOne operations.
type UpdateResult struct {
MatchedCount int64 // The number of documents matched by the filter.
ModifiedCount int64 // The number of documents modified by the operation.
UpsertedCount int64 // The number of documents upserted by the operation.
UpsertedID interface{} // The _id field of the upserted document, or nil if no upsert was done.
}
This is because we could end up with not updating anything if nothing was found. Mongodb does not throw error
jrwbabylonlab
force-pushed
the
consume-fp-event
branch
from
540adac to
564dd26
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.