Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: emit withdrawn and withdrawable events #116

Merged
merged 17 commits into from
Jan 16, 2025

Conversation

gusin13
Copy link
Collaborator

@gusin13 gusin13 commented Jan 14, 2025

@gusin13 gusin13 marked this pull request as ready for review January 15, 2025 06:58
func QualifiedStatesForWithdrawable() []DelegationState {
return []DelegationState{StateUnbonding, StateSlashed, StateWithdrawable}
return []DelegationState{StateActive, StateUnbonding, StateSlashed, StateWithdrawable}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we split the slashing withdrawable and normal withdrawable in here? so that we don't mixed up this slashing edge case with the normal cases.

Copy link
Collaborator Author

@gusin13 gusin13 Jan 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you mean the subStates?

that will be automatically handled when slashing is found by btc notifier and it inserts in the timelock table - code link

Copy link
Collaborator

@jrwbabylonlab jrwbabylonlab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with some comments

@gusin13 gusin13 force-pushed the 188-add-staked-withdrawable-tvl-1-2 branch from ed704fa to b41de44 Compare January 16, 2025 06:29
@gusin13 gusin13 merged commit d0d1caf into main Jan 16, 2025
11 checks passed
@gusin13 gusin13 deleted the 188-add-staked-withdrawable-tvl-1-2 branch January 16, 2025 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants