-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: emit withdrawn and withdrawable events #116
Conversation
func QualifiedStatesForWithdrawable() []DelegationState { | ||
return []DelegationState{StateUnbonding, StateSlashed, StateWithdrawable} | ||
return []DelegationState{StateActive, StateUnbonding, StateSlashed, StateWithdrawable} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could we split the slashing withdrawable
and normal withdrawable
in here? so that we don't mixed up this slashing edge case with the normal cases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did you mean the subStates
?
that will be automatically handled when slashing is found by btc notifier and it inserts in the timelock table - code link
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with some comments
This reverts commit 5fd99d5.
ed704fa
to
b41de44
Compare
Fixes - babylonlabs-io/staking-api-service#188