Replace types.Error with error interface (#122) #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirugan
commented
Jan 16, 2025
| } | ||
|
|
||
| func NewPoller(interval time.Duration, pollMethod func(ctx context.Context) *types.Error) *Poller { | ||
| func NewPoller(interval time.Duration, pollMethod func(ctx context.Context) error) *Poller { |
There was a problem hiding this comment.
return value is used only in this case log.Error().Err(err).Msg("Error polling") which expects error anyway
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just first step to the refactoring, will replace the rest in other PR-s once I'm sure there will be no problems