-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: setup test suite #90
Conversation
1632d4e
to
44e3728
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice work putting all the components together! Some comments can be resolved in a subsequent pr. No blocker
tm.WaitForFinalityProviderStored(t, ctx, fpPK.BtcPk.MarshalHex()) | ||
|
||
// Create BTC delegation without inclusion proof in Babylon node | ||
stakingMsgTx, stakingSlashingInfo, unbondingSlashingInfo, _ := tm.CreateBTCDelegationWithoutIncl(t, fpSK) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that this change for expiry checker is for phase-1 transactions, we should test the case where inclusion proof is included in eoi
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm right, we should test both.
maybe i am wrong but i thought web only supports preapproval flow (in phase2 as well), if the user wants to send inclusion proof he would use the staker cli instead.
i'd need to add separate test for this flow, would be better if i do in next pr (logged a ticket ref)
The bitcoind setup is extremely complex. Is this what's been implemented on core side across multiple services/repos?
|
@jrwbabylonlab hmmm 🤔 did you mean this setup here
happy to jump on call to discuss |
"Do you mean instead of running all this container setup, we have a regtest docker image pushed to registry and then a simple compose file in tests can pull this" Correct |
This pr sets up the full test suite, in short - Babylon node, Bitcoin node and indexer service.
It also sets up the happy case e2e test to verify state transitions and queue events in indexer.
Pending -> Verified -> Unbonding (Early Unbonding)