chore: NewUpgradeConfigurer returns UpgradeConfigurer

babylonlabs-io · Aug 20, 2024 · 746b583 · 746b583
1 parent aaf1495
commit 746b583
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/test/e2e/configurer/factory.go b/test/e2e/configurer/factory.go
@@ -209,7 +209,7 @@ func NewBTCStakingConfigurer(t *testing.T, isDebugLogEnabled bool) (Configurer,
 }
 
 // NewSoftwareUpgradeConfigurer returns a new Configurer for Software Upgrade testing
-func NewSoftwareUpgradeConfigurer(t *testing.T, isDebugLogEnabled bool, upgradePath string, btcHeaders []*btclighttypes.BTCHeaderInfo) (Configurer, error) {
+func NewSoftwareUpgradeConfigurer(t *testing.T, isDebugLogEnabled bool, upgradePath string, btcHeaders []*btclighttypes.BTCHeaderInfo) (*UpgradeConfigurer, error) {
 	identifier := identifierName(t)
 	containerManager, err := containers.NewManager(identifier, isDebugLogEnabled, false, true)
 	if err != nil {

diff --git a/test/e2e/configurer/upgrade.go b/test/e2e/configurer/upgrade.go
@@ -40,7 +40,7 @@ var _ Configurer = (*UpgradeConfigurer)(nil)
 // NewUpgradeConfigurer returns a upgrade configurer, if forkHeight is bigger
 // than 0 it implies that it is a fork upgrade that does not pass by a gov prop
 // if it is set to zero it runs the upgrade by the gov prop.
-func NewUpgradeConfigurer(t *testing.T, chainConfigs []*chain.Config, setupTests setupFn, containerManager *containers.Manager, upgradePlanFilePath string, forkHeight int64) Configurer {
+func NewUpgradeConfigurer(t *testing.T, chainConfigs []*chain.Config, setupTests setupFn, containerManager *containers.Manager, upgradePlanFilePath string, forkHeight int64) *UpgradeConfigurer {
 	t.Helper()
 	return &UpgradeConfigurer{
 		baseConfigurer: baseConfigurer{
@@ -301,7 +301,7 @@ func (uc *UpgradeConfigurer) UpgradeFilePath() (string, error) {
 	return filepath.Join(pwd, uc.upgradeJsonFilePath), nil
 }
 
-// parseGovPropFromFile loads from the file the Upgrade msg.
+// parseGovPropFromFile loads from the file and parse it to the upgrade msg.
 func parseGovPropFromFile(cdc codec.Codec, propFilePath string) (*proposal, *upgradetypes.MsgSoftwareUpgrade, error) {
 	prop, msgs, _, err := parseSubmitProposal(cdc, propFilePath)
 	if err != nil {

diff --git a/test/e2e/software_upgrade_e2e_signet_launch_test.go b/test/e2e/software_upgrade_e2e_signet_launch_test.go
@@ -26,7 +26,7 @@ func (s *SoftwareUpgradeSignetLaunchTestSuite) SetupSuite() {
 
 	cfg, err := configurer.NewSoftwareUpgradeConfigurer(s.T(), true, config.UpgradeSignetLaunchFilePath, []*btclighttypes.BTCHeaderInfo{btcHeaderGenesis})
 	s.NoError(err)
-	s.configurer = cfg.(*configurer.UpgradeConfigurer)
+	s.configurer = cfg
 
 	err = s.configurer.ConfigureChains()
 	s.NoError(err)