Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove devdoc from Makefile and unnecessary replace on go.mod #168

Merged
merged 2 commits into from
Oct 10, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,11 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)

* [#148](https://github.com/babylonlabs-io/babylon/pull/148) Add block results query

### Misc Improvements

* [#168](https://github.com/babylonlabs-io/babylon/pull/168) Remove devdoc from
Makefile and remove unnecessary gin replace.

## v0.12.0

### State Machine Breaking
Expand Down
29 changes: 0 additions & 29 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -138,9 +138,6 @@ help: ## Print this help message

all: tools build lint test ## Run build, lint, and test

# The below include contains the tools and runsim targets.
# TODO: Fix following make file so it will work on linux
# include contrib/devtools/Makefile

###############################################################################
### Build ###
Expand Down Expand Up @@ -399,32 +396,6 @@ gosec-local: ## Run local security checkss

.PHONY: gosec gosec-local

###############################################################################
### Devdoc ###
###############################################################################

DEVDOC_SAVE = docker commit `docker ps -a -n 1 -q` devdoc:local

devdoc-init: ## Initialize documentation
$(DOCKER) run -it -v "$(CURDIR):/go/src/github.com/babylonlabs-io/babylon" -w "/go/src/github.com/babylonlabs-io/babylon" tendermint/devdoc echo
# TODO make this safer
$(call DEVDOC_SAVE)

devdoc: ## Generate documentation
$(DOCKER) run -it -v "$(CURDIR):/go/src/github.com/babylonlabs-io/babylon" -w "/go/src/github.com/babylonlabs-io/babylon" devdoc:local bash

devdoc-save: ## Save documentation changes
# TODO make this safer
$(call DEVDOC_SAVE)

devdoc-clean: ## Clean up documentation artifacts
docker rmi -f $$(docker images -f "dangling=true" -q)

devdoc-update: ## Update documentation tools
docker pull tendermint/devdoc

.PHONY: devdoc devdoc-clean devdoc-init devdoc-save devdoc-update

###############################################################################
### Protobuf ###
###############################################################################
Expand Down
2 changes: 0 additions & 2 deletions cmd/babylond/cmd/genesis.go
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,6 @@ Example:
genesisCliArgs.VoteExtensionEnableHeight,
)
} else if network == "mainnet" {
// TODO: mainnet genesis params
panic("Mainnet params not implemented.")
} else {
return fmt.Errorf("please choose testnet or mainnet")
Expand Down Expand Up @@ -337,7 +336,6 @@ func TestnetGenesisParams(
genParams.MintParams.GoalBonded = sdkmath.LegacyMustNewDecFromStr(fmt.Sprintf("%f", goalBonded))

genParams.GovParams = govv1.DefaultParams()
// TODO investigate those numbers
genParams.GovParams.MinDeposit = sdk.NewCoins(sdk.NewCoin(
genParams.NativeCoinMetadatas[0].Base,
sdkmath.NewInt(2_500_000_000),
Expand Down
3 changes: 0 additions & 3 deletions go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -265,9 +265,6 @@ require (
replace (
// use cosmos fork of keyring
github.com/99designs/keyring => github.com/cosmos/keyring v1.2.0
// Fix upstream GHSA-h395-qcrw-5vmq vulnerability.
// TODO Remove it: https://github.com/cosmos/cosmos-sdk/issues/10409
github.com/gin-gonic/gin => github.com/gin-gonic/gin v1.9.1

github.com/gogo/protobuf => github.com/regen-network/protobuf v1.3.3-alpha.regen.1

Expand Down
Loading
Loading