Properly validate whether tranactions are standard #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KonradStaniec
requested review from
gitferry and
samricotta
and removed request for
a team
KonradStaniec
added
consensus breaking
Lazar955
approved these changes
Oct 13, 2024
| @@ -413,3 +413,148 @@ func TestNotAllowFinalityProviderKeysAsCovenantKeys(t *testing.T) { | |||
| require.Error(t, err) | |||
| require.True(t, errors.Is(err, btcstaking.ErrDuplicatedKeyInScript)) | |||
| } | |||
|
|
|||
| func TestCheckPreSignedTxSanity(t *testing.T) { | |||
| tests := []struct { | |||
| } | ||
| for _, tt := range tests { | ||
| t.Run(tt.name, func(t *testing.T) { | ||
| err := btcstaking.CheckPreSignedTxSanity( |
SebastianElvis
approved these changes
Oct 13, 2024
gitferry
approved these changes
Oct 14, 2024
btcstaking/staking.go
Outdated
| @@ -215,6 +223,89 @@ func IsSimpleTransfer(tx *wire.MsgTx) error { | |||
| return nil | |||
| } | |||
|
|
|||
| // CheckPreSignedTxSanity perfomorms basic checks on a pre-signed transaction: | |||
There was a problem hiding this comment.
Suggested change
| // CheckPreSignedTxSanity perfomorms basic checks on a pre-signed transaction: | |
| // CheckPreSignedTxSanity performs basic checks on a pre-signed transaction: |
I wanted to backport it to release patch version v0.12.1, and bump phase-1 services which use this validation: staking-api, and covenant-emulator. Indexer does not need it as it reads data from BTC ledger, so if miner inserted v0 transaction into the ledger, then indexer must process it |
KonradStaniec
added a commit
that referenced
this pull request
Oct 14, 2024
Add: - new `btcstaking` library function to validate whether transactions are standard based on https://github.com/btcsuite/btcd/blob/ee68dc66a835bf2c9333f3d7b33791841f561c84/mempool/policy.go#L285 - use those function to validate unbonding / slashing transactions - test suite to test new functions
KonradStaniec
added a commit
that referenced
this pull request
Oct 14, 2024
Add: - new `btcstaking` library function to validate whether transactions are standard based on https://github.com/btcsuite/btcd/blob/ee68dc66a835bf2c9333f3d7b33791841f561c84/mempool/policy.go#L285 - use those function to validate unbonding / slashing transactions - test suite to test new functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add:
btcstakinglibrary function to validate whether transactions are standard based on https://github.com/btcsuite/btcd/blob/ee68dc66a835bf2c9333f3d7b33791841f561c84/mempool/policy.go#L285