chore: update exposed db object IndexedBlock in x/finality module
#209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samricotta
requested review from
gitferry and
KonradStaniec
and removed request for
a team
samricotta
changed the title
IndexedBlock in x/finality moduleIndexedBlock in x/finality module
gitferry
approved these changes
Oct 18, 2024
KonradStaniec
approved these changes
Oct 21, 2024
| @@ -146,11 +146,22 @@ message QueryBlockRequest { | |||
| uint64 height = 1; | |||
| } | |||
|
|
|||
| // BlockResponse is the necessary metadata and finalization status of a block | |||
| message BlockResponse { | |||
There was a problem hiding this comment.
I think I would name it IndexedBlockResponse to make it clear that the response contains indexed blocks
Lazar955
approved these changes
Oct 25, 2024
| } | ||
|
|
||
| func convertToIndexedBlockList(brs []*ftypes.IndexedBlockResponse) []*ftypes.IndexedBlock { | ||
| var ibs []*ftypes.IndexedBlock |
| } | ||
|
|
||
| func convertToIndexedBlockResponseList(ibs []*types.IndexedBlock) []*types.IndexedBlockResponse { | ||
| var blockResponses []*types.IndexedBlockResponse |
|
what's the status of this pr? @samricotta |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part closes: https://github.com/babylonlabs-io/pm/issues/72
Currently some of the objects in the babylon apis are exposed and need to be handled correctly seen in https://github.com/babylonlabs-io/pm/issues/72
This PR handles the exposed objects in x/finality
Specifically the
IndexedBlockobject.