zoneconcierge: replace chain ID with client ID for consumers #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SebastianElvis
changed the title
SebastianElvis
requested review from
gitferry,
KonradStaniec,
maurolacy and
gusin13
KonradStaniec
added
consensus breaking
|
Putting this PR on hold for now. Another way of resolving this issue is to enforce each chain ID to only have 1 IBC client in record. This is followed by ICS. Will need to investigate further and provide a concrete design |
Lazar955
approved these changes
Aug 20, 2024
1 task
SebastianElvis
added a commit
that referenced
this pull request
Aug 27, 2024
Subsumes #22 --- Fixes babylonlabs-io/pm#12 This PR replaces the chain ID with the client ID for consumers in the BTC timestamping protocol. This is in line with [the IBC security model](https://tutorials.cosmos.network/academy/3-ibc/1-what-is-ibc.html) where each IBC light client corresponds to a chain, and with the BTC staking integration implementation. The PR includes: - renaming all chain ID to consumer ID, same as BTC staking integration does - using client ID to identify {epoch, finalised} chain info - changing all queries, fuzz tests, e2e tests, and doc accordingly TODO before merging the PR: - [x] wait until @gitferry verifies we can do software upgrade with empty DB and updated DB schema Plan after the PR: - Fixing compatiblity with BE/FE (need arch decisions here)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/babylonlabs-io/pm/issues/12
This PR replaces the chain ID with the client ID for consumers in the BTC timestamping protocol. This is in line with the IBC security model where each IBC light client corresponds to a chain, and with the BTC staking integration implementation.
The PR includes:
TODO before merging the PR:
Plan after the PR: