Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ADR-036): custom withdrawal address #309

Merged
merged 6 commits into from
Dec 3, 2024
Merged

feat(ADR-036): custom withdrawal address #309

merged 6 commits into from
Dec 3, 2024

Conversation

Lazar955
Copy link
Member

@Lazar955 Lazar955 commented Dec 2, 2024

Adds the ability to specify custom address to separate operational and rewards address

References ADR-036

@Lazar955 Lazar955 requested a review from a team as a code owner December 2, 2024 10:10
@Lazar955 Lazar955 requested review from RafilxTenfen and samricotta and removed request for a team December 2, 2024 10:10
@Lazar955 Lazar955 changed the title feat(ADR-036) custom withdrawal address feat(ADR-036): custom withdrawal address Dec 2, 2024
RafilxTenfen
RafilxTenfen approved these changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@RafilxTenfen RafilxTenfen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I think we should also add a query to verify which is the current withdrawal addr

gitferry
gitferry approved these changes Dec 2, 2024
View reviewed changes
Copy link
Member

@gitferry gitferry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

x/incentive/keeper/msg_server_test.go Show resolved Hide resolved
x/incentive/keeper/query_delegator.go Outdated Show resolved Hide resolved
@Lazar955 Lazar955 merged commit 92b8f3a into main Dec 3, 2024
19 checks passed
@Lazar955 Lazar955 deleted the lazar/adr-036-custom-withdrawal-address branch December 3, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RafilxTenfen RafilxTenfen RafilxTenfen approved these changes

@gitferry gitferry gitferry approved these changes

@samricotta samricotta Awaiting requested review from samricotta samricotta was automatically assigned from babylonlabs-io/core-dev

@KonradStaniec KonradStaniec Awaiting requested review from KonradStaniec

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Lazar955 @gitferry @RafilxTenfen