adr-37 parameters for btc light client ranges #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…de data, from BtcStakingParamStr to BtcStakingParamsStr and removed string quotes from int types
RafilxTenfen
reviewed
Dec 2, 2024
|
|
||
| for _, p := range params { | ||
| // using set Params here makes sure the parameters in the upgrade string are consistent | ||
| err = k.SetParams(ctx, p) |
There was a problem hiding this comment.
this test checks that the params in the upgrade are consistent by passing through the AddNewPair
but during the upgrade it is overwritten the entire set of params
@KonradStaniec
RafilxTenfen
reviewed
Dec 2, 2024
| "delegation_creation_base_gas_fee": 1000, | ||
| "allow_list_expiration_height": 0 | ||
| }` | ||
| const BtcStakingParamsStr = `[ |
There was a problem hiding this comment.
basically just copy&paste 3 times to check if all of those were inserted with a different btc_activation_height
RafilxTenfen
reviewed
Dec 2, 2024
| @@ -1,7 +1,7 @@ | |||
| package v1 | |||
|
|
|||
| type UpgradeDataString struct { | |||
| BtcStakingParamStr string | |||
| BtcStakingParamsStr string | |||
There was a problem hiding this comment.
@babylon-devops modified this to BtcStakingParamStr => BtcStakingParamsStr since now it is a slice of parameters
RafilxTenfen
requested review from
RafilxTenfen,
samricotta,
a team,
gitferry and
Lazar955
and removed request for
a team
gitferry
approved these changes
Dec 3, 2024
| }) | ||
| } | ||
|
|
||
| func (m *HeightToVersionMap) AddPair(newPair *HeightVersionPair) error { |
There was a problem hiding this comment.
Better to add a doc string here
| // QueryParamsByBTCHeightResponse is response type for the Query/QueryParamsByBTCHeightResponse RPC method. | ||
| message QueryParamsByBTCHeightResponse { | ||
| // params holds all the parameters of this module. | ||
| Params params = 1 [(gogoproto.nullable) = false]; |
There was a problem hiding this comment.
would it be helpful to also have version number here?
There was a problem hiding this comment.
probably 👍 good idea
KonradStaniec
deleted the
konradstaniec/adr-37-parameters-for-btc-light-client-ranges
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.