Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix getStatus call on BTCDelegation #318

Merged
merged 2 commits into from
Dec 4, 2024
Merged

fix getStatus call on BTCDelegation #318

merged 2 commits into from
Dec 4, 2024

Conversation

KonradStaniec
Copy link
Collaborator

With recent changes:

  • enforcing that min_unbonding_time is always larger than checkpoint_finalization_timeout
  • changing min_unbonding_time to exact unbonding_time

GetStatus can now rely on UnbondingTime in delegation instead of checkpoint_finalization_timeout

@KonradStaniec KonradStaniec requested a review from a team as a code owner December 4, 2024 12:28
@KonradStaniec KonradStaniec requested review from RafilxTenfen and samricotta and removed request for a team December 4, 2024 12:28
RafilxTenfen
RafilxTenfen approved these changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@RafilxTenfen RafilxTenfen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, LGTM 🎉

@KonradStaniec KonradStaniec merged commit aa32cd4 into main Dec 4, 2024
19 checks passed
@KonradStaniec KonradStaniec deleted the konradstaniec/fix-status-check branch December 4, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RafilxTenfen RafilxTenfen RafilxTenfen approved these changes

@samricotta samricotta Awaiting requested review from samricotta samricotta was automatically assigned from babylonlabs-io/core-dev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KonradStaniec @RafilxTenfen