Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Decrementing jailed fp counter #324

Merged
merged 3 commits into from
Dec 5, 2024

Conversation

gitferry
Copy link
Member

@gitferry gitferry commented Dec 5, 2024

Closes #259. Using gauge is not easy to fix the issue as we don't know the number of fps being jailed. Therefore, this PR fixed the issue by adding a separate counter for unjailed fps.

@gitferry gitferry requested a review from filippos47 December 5, 2024 08:24
@gitferry gitferry marked this pull request as ready for review December 5, 2024 08:45
@gitferry gitferry requested a review from a team as a code owner December 5, 2024 08:45
@gitferry gitferry requested review from KonradStaniec and RafilxTenfen and removed request for a team December 5, 2024 08:45
@gitferry gitferry merged commit 213b1ae into main Dec 5, 2024
19 checks passed
@gitferry gitferry deleted the gai/fix-decrementing-jailed-fp-metrics branch December 5, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Decrementing jailed_finality_provider_counter Prom metric fails
2 participants