chore(adr-39): Reject out-dated finality votes #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gitferry
requested review from
KonradStaniec,
RafilxTenfen,
Lazar955 and
a team
and removed request for
a team
KonradStaniec
approved these changes
Dec 20, 2024
x/finality/keeper/msg_server.go
Outdated
| @@ -210,6 +218,24 @@ func (ms msgServer) AddFinalitySig(goCtx context.Context, req *types.MsgAddFinal | |||
| return &types.MsgAddFinalitySigResponse{}, nil | |||
| } | |||
|
|
|||
| func (ms msgServer) ShouldAcceptSigForHeight(ctx context.Context, height uint64) (bool, error) { | |||
| // check if the block is finalized and timestamped | |||
| indexedBlock, err := ms.GetBlock(ctx, height) | |||
There was a problem hiding this comment.
when verifying sig we retrieve block:
// the public randomness is good, set the public randomness
ms.SetPubRand(ctx, req.FpBtcPk, req.BlockHeight, *req.PubRand)
// verify whether the voted block is a fork or not
indexedBlock, err := ms.GetBlock(ctx, req.BlockHeight)
if err != nil {
return nil, err
}
later for different purposes.
Maybe we can pass indexed block to this function to avoid one db read ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.