Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use errors.New to replace fmt.Errorf with no parameters #370

Closed
wants to merge 1 commit into from
Closed

chore: use errors.New to replace fmt.Errorf with no parameters #370

wants to merge 1 commit into from

Conversation

RiceChuan
Copy link

use errors.New to replace fmt.Errorf with no parameters

@RiceChuan RiceChuan requested a review from a team as a code owner December 23, 2024 06:48
@RiceChuan RiceChuan requested review from KonradStaniec and Lazar955 and removed request for a team December 23, 2024 06:48
laciferin2024
laciferin2024 reviewed Dec 24, 2024
View reviewed changes
Copy link

@laciferin2024 laciferin2024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fmt.Errorf : is not deprecated AFAIK and is more convenient and idiomatic for programmatic errors.

@gitferry gitferry closed this Jan 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laciferin2024 laciferin2024 laciferin2024 left review comments

@KonradStaniec KonradStaniec Awaiting requested review from KonradStaniec KonradStaniec was automatically assigned from babylonlabs-io/core-dev

@Lazar955 Lazar955 Awaiting requested review from Lazar955 Lazar955 was automatically assigned from babylonlabs-io/core-dev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RiceChuan @laciferin2024 @gitferry