fix: Safely handle db.Iterator and itr.Error errors to prevent resource leaks
#382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ce leaks This PR modifies the error handling in PrintDBStats by replacing panic calls with returned errors. Specifically: - db.Iterator errors now return a formatted error instead of causing a panic. - itr.Error is also handled gracefully by returning an error. Signed-off-by: Hwangjae Lee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR modifies the error handling in PrintDBStats by replacing panic calls with returned errors. Specifically:
Motivation
In the current code, if db.Iterator() or itr.Error() causes a panic,
the defer itr.Close() might not be called. Depending on the database
implementation, resources may not be automatically cleaned up, which could
result in:
This PR ensures that the iterator is closed properly even when errors occur.
If this behavior is already expected or deemed unnecessary, this PR can be
closed without merging.