Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix comments to the base branch #418

Merged
merged 5 commits into from
Jan 17, 2025
Merged

fix: fix comments to the base branch #418

merged 5 commits into from
Jan 17, 2025

Conversation

SebastianElvis
Copy link
Member

This PR fixes the comments to the base branch at #402, including

  • bumping relayer/grpc version in go.mod
  • fixing proto
  • using iterator and handler function to avoid saving all BTC delegations in memory upon slashing
  • removing unused code
  • removing duplicated checks introduced due to rebase

@SebastianElvis SebastianElvis mentioned this pull request Jan 17, 2025
Open
@SebastianElvis SebastianElvis merged commit 873f123 into base/consumer-chain-support Jan 17, 2025
19 of 20 checks passed
@SebastianElvis SebastianElvis deleted the fix-comments-on-base branch January 17, 2025 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KonradStaniec KonradStaniec KonradStaniec approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SebastianElvis @KonradStaniec