Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix comments to the base branch 2 #424

Open
wants to merge 1 commit into
base: base/consumer-chain-support
Choose a base branch
from

Conversation

SebastianElvis
Copy link
Member

Fix comments in #402

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tmp-swagger-gen/* usually is removed after the run

rm -rf ./tmp-swagger-gen

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm ok, somehow make proto-swagger-gen does not automatically remove these. Any ideas?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on this branch I get one error

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generating Protobuf Swagger
Error opening file "/workspace/tmp-swagger-gen/babylon/incentive/v1/query.swagger.json" 
ENOENT: no such file or directory, open '/workspace/tmp-swagger-gen/babylon/incentive/v1/query.swagger.json'
make: *** [Makefile:423: proto-swagger-gen] Error 1

Copy link
Contributor

@RafilxTenfen RafilxTenfen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM besides the files inside tmp-swagger-gen

Copy link
Member

@Lazar955 Lazar955 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants