-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix comments to the base branch 2 #424
base: base/consumer-chain-support
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tmp-swagger-gen/* usually is removed after the run
rm -rf ./tmp-swagger-gen |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm ok, somehow make proto-swagger-gen
does not automatically remove these. Any ideas?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
on this branch I get one error
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generating Protobuf Swagger
Error opening file "/workspace/tmp-swagger-gen/babylon/incentive/v1/query.swagger.json"
ENOENT: no such file or directory, open '/workspace/tmp-swagger-gen/babylon/incentive/v1/query.swagger.json'
make: *** [Makefile:423: proto-swagger-gen] Error 1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM besides the files inside tmp-swagger-gen
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work!
Fix comments in #402