chore(ADR-024): Rebase to main #48
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Subsumes #22 --- Fixes babylonlabs-io/pm#12 This PR replaces the chain ID with the client ID for consumers in the BTC timestamping protocol. This is in line with [the IBC security model](https://tutorials.cosmos.network/academy/3-ibc/1-what-is-ibc.html) where each IBC light client corresponds to a chain, and with the BTC staking integration implementation. The PR includes: - renaming all chain ID to consumer ID, same as BTC staking integration does - using client ID to identify {epoch, finalised} chain info - changing all queries, fuzz tests, e2e tests, and doc accordingly TODO before merging the PR: - [x] wait until @gitferry verifies we can do software upgrade with empty DB and updated DB schema Plan after the PR: - Fixing compatiblity with BE/FE (need arch decisions here)
Add codeowners files to the repository
Refactor our staking handler. Pre-requisite before implementing: https://github.com/babylonlabs-io/pm/blob/main/adr/adr-023-update-btcstaking-params.md
- Load signed `MsgCreateFinalityProvider` from json string - Add finality providers in upgrade - Check finality providers in e2e upgrade signet Same as #28
…ed pub rand (#23) This closes the second part of #8. In particular, this PR: * Implemented `HasTimestampedPubRand` in the finality keeper to check whether a pub rand at a given height is BTC-timestamped * Added expected finality keeper to btcstaking keeper so that `HasTimestampedPubRand` can be called within the module * When signing voting power to fps in `btcstaking`'s begin blocker, if the fp does not have timestamped pub rand, voting power will not be assigned Note that this PR introduced circular dependency between the btc staking module and finality module, which should be addressed by moving the voting power table to the finality module, tracked by issue #24
This PR fixed some issues in assigning the voting power, in particular * even if no new delegations are included, we should also update the cache about the timestamping status * fixed return value of `HasTimestampedPubRand` * e2e tests are fixed * added table-driven tests for the voting table
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.