Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improve IBC packet structure #480

Merged
merged 4 commits into from
Feb 10, 2025
Merged

feat: improve IBC packet structure #480

merged 4 commits into from
Feb 10, 2025

Conversation

gusin13
Copy link
Contributor

@gusin13 gusin13 commented Feb 5, 2025 •
edited
Loading

@gusin13 gusin13 force-pushed the gusin13/refactor-ibc-packets1 branch from e5739b2 to 533260d Compare February 7, 2025 13:12
@gusin13 gusin13 force-pushed the gusin13/refactor-ibc-packets1 branch from 58f8e83 to 27cb278 Compare February 9, 2025 13:09
@gusin13 gusin13 marked this pull request as ready for review February 9, 2025 13:12
SebastianElvis
SebastianElvis approved these changes Feb 10, 2025
View reviewed changes
Copy link
Member

@SebastianElvis SebastianElvis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much cleaner!

proto/babylon/zoneconcierge/v1/packet.proto Show resolved Hide resolved
proto/babylon/zoneconcierge/v1/packet.proto Show resolved Hide resolved
maurolacy
maurolacy approved these changes Feb 10, 2025
View reviewed changes
Copy link
Contributor

@maurolacy maurolacy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@gusin13 gusin13 merged commit 81de517 into main Feb 10, 2025
24 checks passed
@gusin13 gusin13 deleted the gusin13/refactor-ibc-packets1 branch February 10, 2025 09:07
@gusin13 gusin13 mentioned this pull request Feb 10, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SebastianElvis SebastianElvis SebastianElvis approved these changes

@maurolacy maurolacy maurolacy approved these changes

@gitferry gitferry Awaiting requested review from gitferry

@KonradStaniec KonradStaniec Awaiting requested review from KonradStaniec

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gusin13 @SebastianElvis @maurolacy