fix: display error for untouched hidden field (#84)

babylonlabs-io · Jan 6, 2025 · 99f593f · 99f593f
1 parent cf53263
commit 99f593f
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 10 deletions.
diff --git a/.changeset/smart-tools-fail.md b/.changeset/smart-tools-fail.md
@@ -0,0 +1,5 @@
+---
+"@babylonlabs-io/bbn-core-ui": patch
+---
+
+fix hidden field
diff --git a/src/widgets/form/HiddenField/HiddenField.tsx b/src/widgets/form/HiddenField/HiddenField.tsx
@@ -7,19 +7,22 @@ export interface HiddenFieldProps extends FieldProps {
 }
 
 export function HiddenField({ displayError = false, ...props }: HiddenFieldProps) {
-  const { invalid, error, value, onChange, onBlur, disabled, name, ref } = useField(props);
+  const { error, value, onChange, onBlur, disabled, name, ref } = useField(props);
 
-  const fieldState = invalid && displayError ? "error" : "default";
-  const fieldHint = invalid && displayError ? error : "";
   const input = (
     <input ref={ref} type="hidden" name={name} disabled={disabled} value={value} onChange={onChange} onBlur={onBlur} />
   );
 
-  return displayError ? (
-    <FormControl hint={fieldHint} state={fieldState}>
-      {input}
-    </FormControl>
-  ) : (
-    input
-  );
+  if (displayError) {
+    const fieldState = displayError ? "error" : "default";
+    const fieldHint = displayError ? error : "";
+
+    return (
+      <FormControl hint={fieldHint} state={fieldState}>
+        {input}
+      </FormControl>
+    );
+  }
+
+  return input;
 }